Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement schemas and routes #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Mxbely
Copy link

@Mxbely Mxbely commented Jan 17, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the core functionality and meeting the task requirements! 🎉 While there are a few minor issues, such as redundant type hints and hardcoded pagination links, they don't significantly impact the functionality. Keep up the good work, and consider addressing these minor issues for cleaner and more maintainable code in the future. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

.gitignore Show resolved Hide resolved
src/routes/movies.py Outdated Show resolved Hide resolved
src/routes/movies.py Outdated Show resolved Hide resolved
src/routes/movies.py Outdated Show resolved Hide resolved
src/schemas/movies.py Show resolved Hide resolved
src/schemas/movies.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants